Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pref: fix version flag handling #21377

Merged
merged 4 commits into from
Apr 29, 2024
Merged

pref: fix version flag handling #21377

merged 4 commits into from
Apr 29, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 29, 2024

Current:

❯ v --version
V 0.4.5 3226365
❯ v retry --version
V 0.4.5 3226365
❯ v retry -- git --version
V 0.4.5 3226365

Updated:

❯ v --version
V 0.4.5 21b76c1
❯ v retry --version
v retry 0.0.1
❯ v retry -- git --version
git version 2.44.0

@ttytm ttytm marked this pull request as draft April 29, 2024 13:49
@ttytm ttytm force-pushed the pref/fix-version-flag branch 2 times, most recently from 6d302f2 to bfeb02f Compare April 29, 2024 14:41
@ttytm ttytm marked this pull request as ready for review April 29, 2024 14:44
@ttytm
Copy link
Member Author

ttytm commented Apr 29, 2024

Further fixes:
Current:

❯ v -cc gcc -v
v: unknown command ``

Updated:

❯ v -cc gcc -v
V 0.4.5 c85c177

@ttytm ttytm force-pushed the pref/fix-version-flag branch 3 times, most recently from 945fdec to 4038615 Compare April 29, 2024 15:11
@spytheman spytheman merged commit 08da3cd into vlang:master Apr 29, 2024
53 checks passed
@ttytm ttytm deleted the pref/fix-version-flag branch April 29, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttytm @spytheman